Create gaussian_discriminant_analysis.py#19
Open
Christakou wants to merge 1 commit intoddbourgin:masterfrom
Christakou:master
Open
Create gaussian_discriminant_analysis.py#19Christakou wants to merge 1 commit intoddbourgin:masterfrom Christakou:master
Christakou wants to merge 1 commit intoddbourgin:masterfrom
Christakou:master
Conversation
WuZhuoran
reviewed
Jul 11, 2019
| @@ -0,0 +1,45 @@ | |||
| import numpy as np | |||
| import pandas as pd | |||
Contributor
There was a problem hiding this comment.
It seems that you did not use pandas package in your code. So I think you could remove this line.
Contributor
|
Could you please create unit test for this? Maybe you can refer sklearn-test for details. |
Owner
|
Hi @Christakou - thanks for the submission! A few general comments:
You can see the general contribution guidelines here. Let me know if you have questions ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A framework for building general discriminant analysis models, currently implemented quadratic discriminant analysis, will later add support for linear discriminant analysis too.